Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --root-mode option in babel-node #9148

Merged
merged 1 commit into from Dec 7, 2018

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 7, 2018

Q                       A
Fixed Issues? Fixes #9137
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Dec 7, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9578/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Dec 7, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9578/

@zefexdeveloper

This comment has been minimized.

Copy link

zefexdeveloper commented Dec 7, 2018

Amazing, thank you @nicolo-ribaudo, can't wait for this to get merged.

Copy link
Member

existentialism left a comment

lol how'd we both miss this?

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 7, 2018

Don't know lol 😆

@nicolo-ribaudo nicolo-ribaudo merged commit 9b005de into babel:master Dec 7, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.72% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:fix-9137 branch Dec 7, 2018
@loganfsmyth

This comment has been minimized.

Copy link
Member

loganfsmyth commented Dec 7, 2018

Oh huh, wasn't there a test?

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 7, 2018

Nope, many babel-node options aren't tested because they only forward a parameter to babel-core. Also, I'm not sure that we can test this option with the current @babel/node test infrastructure because it requires changing the cwd to a subpackage, right?
@wtgtybhertgeghgtwtg If it is possible, do you want to add a test for this option?

@loganfsmyth

This comment has been minimized.

Copy link
Member

loganfsmyth commented Dec 7, 2018

That'll teach me I guess :p Thanks for fixing.

@zefexdeveloper

This comment has been minimized.

Copy link

zefexdeveloper commented Dec 8, 2018

@nicolo-ribaudo @existentialism I still can't use it, am I missing something here?

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 8, 2018

We didn't release it yet

@zefexdeveloper

This comment has been minimized.

Copy link

zefexdeveloper commented Dec 8, 2018

@nicolo-ribaudo Oh, got it, I thought it was released. I will wait then 😄

@wtgtybhertgeghgtwtg

This comment has been minimized.

Copy link
Contributor

wtgtybhertgeghgtwtg commented Dec 10, 2018

Wow, how did I screw up that badly?

If it is possible, do you want to add a test for this option?

I'm sorry, I can't figure out a good way to do that with the current setup.

@zefexdeveloper

This comment has been minimized.

Copy link

zefexdeveloper commented Dec 11, 2018

@wtgtybhertgeghgtwtg It happens, someone would find out eventually. 🤣

@casesandberg

This comment has been minimized.

Copy link

casesandberg commented Dec 29, 2018

Has this been released? Still having the same problem.

api > @babel/node@7.2.2
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 29, 2018

It seems to work for me 🤔

  babel-test > @babel/node@^7.2.2


Documenti/dev/babel-test is 📦 v1.0.0 via ⬢ v10.14.2 took 5s 
➜ yarn run babel-node --root-mode upward
yarn run v1.12.3
$ /home/nicolo/Documenti/dev/babel-test/node_modules/.bin/babel-node --root-mode upward
> 

Can you share a precise example which shows the problem_

@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.