Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transforming empty export statement #9171

Merged
merged 1 commit into from Dec 13, 2018

Conversation

@danez
Copy link
Member

danez commented Dec 12, 2018

Q                       A
Fixed Issues? Fixes #9155
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This adds a new flag indicating if the module has exports and removes the current logic to detect that. This fixes the case when an export statement is present but does not really export anything: export {}

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Dec 12, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9601/

@@ -52,18 +54,7 @@ export type LocalExportMetadata = {
* Check if the module has any exports that need handling.
*/
export function hasExports(metadata: ModuleMetadata) {

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Dec 12, 2018

Member

Is this function still needed?

This comment has been minimized.

Copy link
@danez

danez Dec 12, 2018

Author Member

No, but as it is a separate package I cannot remove it without breaking backwards compatibility if a mix between old and new version of Babel packages is used. At first I also wanted to use meta.hasExports directly in the transforms, but I ended up not doing it for the same reason.

Copy link
Member

loganfsmyth left a comment

Thanks!

@danez danez merged commit f4eec5c into babel:master Dec 13, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.72% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez danez deleted the danez:fix-9155 branch Dec 13, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.