Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test262 update #9288

Merged
merged 3 commits into from Jan 7, 2019
Merged

Test262 update #9288

merged 3 commits into from Jan 7, 2019

Conversation

@existentialism
Copy link
Member

existentialism commented Jan 6, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Will follow-up this up with a few PRs to fix some spec parsing issues.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jan 6, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9707/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jan 6, 2019

We should sort alphabetically the whitelist so that it is actually possible to see the real changes.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jan 6, 2019

I think that it should be done by the script that generates the file, otherwise it will get out of order again. It can be done in another PR if you prefer.

@existentialism existentialism force-pushed the test262-update branch from b1b1480 to 5d1a68f Jan 6, 2019
@existentialism

This comment has been minimized.

Copy link
Member Author

existentialism commented Jan 6, 2019

@hzoo
hzoo approved these changes Jan 7, 2019
Copy link
Member

hzoo left a comment

lgtm

@danez
danez approved these changes Jan 7, 2019
@existentialism existentialism merged commit a55382e into master Jan 7, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.66% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the test262-update branch Jan 7, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.