Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling newline with TypeScript declare and abstract classes #9328

Merged
merged 4 commits into from Jan 15, 2019

Conversation

@existentialism
Copy link
Member

existentialism commented Jan 13, 2019

Q                       A
Fixed Issues? Fixes #9325
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jan 13, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9790/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jan 13, 2019

Can you also add the check for type aliases? These should be two statements:

type
Foo = string;
@existentialism existentialism force-pushed the issue9325 branch from a105357 to 8159676 Jan 14, 2019
@existentialism

This comment has been minimized.

Copy link
Member Author

existentialism commented Jan 14, 2019

@nicolo-ribaudo updated (was going to originally save it for a follow up pr)

@existentialism existentialism merged commit aaec2cd into master Jan 15, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.69% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the issue9325 branch Jan 15, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.