Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/traverse: Fix NodePath.getData #9415

Merged
merged 3 commits into from Mar 26, 2019

Conversation

@71
Copy link
Contributor

commented Jan 26, 2019

Q                       A
Fixed Issues? None.
Patch: Bug Fix? Yup.
Major: Breaking Change? Nope.
Minor: New Feature? Nope.
Tests Added + Pass? Nope.
Documentation PR Link N/A.
Any Dependency Changes? Nope.
License MIT

Currently, if the obtained value is false, it will be replaced by the given default value, which is invalid. This makes sure that we only set the default value when the value is undefined, instead of falsy.

Currently, if the obtained value is `false`, it will be replaced by the given default value, which is invalid. This makes sure that we only set the default value when the value is `undefined`, instead of falsy.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jan 26, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9919/

@danez

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

I added some tests and also ensured that the object protoype is not interfering.

And also allow everything that is not undefined as default value

@danez

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

The error is unrelated to this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.