New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow to 0.92.1 and fix related issues #9468

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@danez
Copy link
Member

danez commented Feb 7, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? flow
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 7, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10009/

@@ -127,7 +127,7 @@ function transformFile(file: File, pluginPasses: PluginPasses): void {
}
}

function isThenable(val: mixed): boolean {

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo Feb 7, 2019

Member

I don't think that this is correct: val can be anything. Does something like this work?

functin isThenable(val: mixed): boolean %checks (val instanceof Promise) {
  //...
}

https://flow.org/try/#0CYUwxgNghgTiAEAzArgOzAFwJYHtXywGcAVACxFSgCMIQAKANyggC54BbLADxGAEo2VHDlpR8AUjDkwAa0LxGzAqkIYxYEDkTwACjBydCIPgG4AUGdCRYCJjHhc2nHsHNms2ukTIVqtOlx8fPAA3mbwDgB0GOSodKZmAL7wIBBGoeFRMRTx5olAA

This comment has been minimized.

@danez

danez Feb 7, 2019

Author Member

I changed it

@danez danez removed the PR: Internal 🏠 label Feb 7, 2019

@danez danez merged commit 7943a48 into babel:master Feb 8, 2019

4 checks passed

babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 81.46% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danez danez deleted the danez:flow-update branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment