Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate-package-checker-webpack-plugin #9517

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Feb 15, 2019

Q                       A
Tests Added + Pass? Yes
Any Dependency Changes?
License MIT

As suggested by @danez, this can help preventing problems like #9516.

babel on  master [$+?] via ⬢ v10.14.2 
➜ make build-standalone           
./node_modules/.bin/gulp build-babel-standalone
[10:43:51] Using gulpfile ~/Documenti/dev/babel/babel/Gulpfile.js
[10:43:51] Starting 'build-babel-standalone'...
[10:44:00] Version: webpack 3.11.0
   Asset     Size  Chunks                    Chunk Names
babel.js  2.87 MB       0  [emitted]  [big]  main

WARNING in semver
  Multiple versions of semver found:
    5.5.0 ./~/semver
    5.6.0 ./packages/babel-plugin-transform-runtime/~/semver

Check how you can resolve duplicate packages: 
https://github.com/darrenscerri/duplicate-package-checker-webpack-plugin#resolving-duplicate-packages-in-your-bundle

[10:44:00] Skipped minification of 'packages/babel-standalone/babel.js' because not publishing
[10:44:00] Finished 'build-babel-standalone' after 9.14 s



babel on  master [$!?] via ⬢ v10.14.2 took 9s 
➜ make build-preset-env-standalone
./node_modules/.bin/gulp build-babel-preset-env-standalone
[10:43:25] Using gulpfile ~/Documenti/dev/babel/babel/Gulpfile.js
[10:43:25] Starting 'build-babel-preset-env-standalone'...
[10:43:32] Version: webpack 3.11.0
              Asset    Size  Chunks                    Chunk Names
babel-preset-env.js  2.1 MB       0  [emitted]  [big]  main
[10:43:32] Skipped minification of 'packages/babel-preset-env-standalone/babel-preset-env.js' because not publishing
[10:43:32] Finished 'build-babel-preset-env-standalone' after 6.93 s

We are duplicating semver. It's such a small package that I don't think that it is worth spending much time trying to understand why.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 15, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10105/

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 15, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10103/

@danez

This comment has been minimized.

Copy link
Member

danez commented Feb 15, 2019

If we don't care for now about semver, we should add it to the whitelist. https://github.com/darrenscerri/duplicate-package-checker-webpack-plugin#configuration

@danez
danez approved these changes Feb 15, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit d86b831 into babel:master Feb 15, 2019
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.98% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:duplicate-package-checker-webpack-plugin branch Feb 15, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.