Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eqeqeq rule in eslint #9541

Merged
merged 1 commit into from Feb 19, 2019

Conversation

@danez
Copy link
Member

danez commented Feb 19, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Enforce === and !== except when comparing to null.

We only had three cases that errored.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 19, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10173/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 19, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10173/

Copy link
Member

nicolo-ribaudo left a comment

We should go through all the eslint rules and decide what to enable

@danez danez merged commit b78fdc0 into babel:master Feb 19, 2019
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez danez deleted the danez:eqeqeq branch Feb 19, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.