Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform Tagged Template Literals in Safari #9584

Closed
wants to merge 1 commit into from

Conversation

@jridgewell
Copy link
Member

commented Feb 25, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? N/a
Documentation PR Link
Any Dependency Changes?
License MIT

Safari 12 has a bug that breaks caching of TaggedTemplateExpressions.

Ideally, we'd be able to break up the template literals feature into
two:

  1. Regular template literals
  2. Tagged template literals

We only need to transform tagged template literals. Also, Safari 9-11
don't have this issue, so we could avoid transforming in all cases if
we could specify that in the json.

Un-transformed test: https://jsbin.com/leyusas/10/edit?js,console
Transform test: https://jsbin.com/leyusas/8/edit?js,console

Transform Tagged Template Literals in Safari
Safari 12 has a [bug](https://bugs.webkit.org/show_bug.cgi?id=190756) that breaks caching of `TaggedTemplateExpression`s.

Ideally, we'd be able to break up the template literals feature into
two:

1. Regular template literals
2. Tagged template literals

We only need to transform tagged template literals. Also, Safari 9-11
don't have this issue, so we avoid it if we could specify that in the
json.

Un-transformed test: https://jsbin.com/leyusas/10/edit?js,console
Transform test: https://jsbin.com/leyusas/8/edit?js,console
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Since this file is auto-generated, this needs to be updated in compat-table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.