Transform Tagged Template Literals in Safari #9584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari 12 has a [bug](https://bugs.webkit.org/show_bug.cgi?id=190756) that breaks caching of `TaggedTemplateExpression`s. Ideally, we'd be able to break up the template literals feature into two: 1. Regular template literals 2. Tagged template literals We only need to transform tagged template literals. Also, Safari 9-11 don't have this issue, so we avoid it if we could specify that in the json. Un-transformed test: https://jsbin.com/leyusas/10/edit?js,console Transform test: https://jsbin.com/leyusas/8/edit?js,console
|
Since this file is auto-generated, this needs to be updated in |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 12 has a bug that breaks caching of
TaggedTemplateExpressions.Ideally, we'd be able to break up the template literals feature into
two:
We only need to transform tagged template literals. Also, Safari 9-11
don't have this issue, so we could avoid transforming in all cases if
we could specify that in the json.
Un-transformed test: https://jsbin.com/leyusas/10/edit?js,console
Transform test: https://jsbin.com/leyusas/8/edit?js,console