Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat for loop body as part of loop scope #9586

Merged
merged 1 commit into from Feb 26, 2019
Merged

Treat for loop body as part of loop scope #9586

merged 1 commit into from Feb 26, 2019

Conversation

@danez
Copy link
Member

danez commented Feb 25, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Rejects for (let i = 0;;) { var i } but keeps for (let i = 0;;) { let i } valid

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 25, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10284/

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Feb 25, 2019
@danez danez force-pushed the danez:for-loop branch from ed19bab to c9cb5e2 Feb 25, 2019
@danez danez merged commit d0e196d into babel:master Feb 26, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No prior size to compare - 7.37 MB
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Feb 26, 2019
@danez danez deleted the danez:for-loop branch Feb 26, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.