Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow duplicate params in methods #9599

Merged
merged 2 commits into from Feb 27, 2019
Merged

Disallow duplicate params in methods #9599

merged 2 commits into from Feb 27, 2019

Conversation

@danez
Copy link
Member

danez commented Feb 27, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

https://www.ecma-international.org/ecma-262/9.0/#sec-function-definitions-static-semantics-early-errors

UniqueFormalParameters: FormalParameters

  • It is a Syntax Error if BoundNames of FormalParameters contains any
    duplicate elements.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 27, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10324/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 27, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10324/

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Feb 27, 2019
@danez danez merged commit 208195f into babel:master Feb 27, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.99% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Feb 27, 2019
@danez danez deleted the danez:duplicate-params branch Feb 27, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.