Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parsing object members #9607

Merged
merged 5 commits into from Feb 28, 2019

Conversation

@danez
Copy link
Member

danez commented Feb 28, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This makes some changes around destructuring, restspread and objects.

  • Split the actual parsing of object-members from parseObj()-loop into parseObjectMember.
  • Parse RestElement in parseObjectMember not with parseSpread() + toAssignable() as that seems an overkill if we can parse it directly.
  • Parse RestElement in parseObjectMember not with parseRest() as only Identifier is allowed in this context
  • Do allow object shorthand property duplicates named __proto__. The spec specifically says only duplicates which come from the form *PropertyDefinition: PropertyName : AssignmentExpression* : https://www.ecma-international.org/ecma-262/9.0/index.html#sec-__proto__-property-names-in-object-initializers
  • Disallow a newline between async and method name.
  • Refactored the trailing comma after rest element messages. We had lots of different variations for this error and I opted to go for one message for all cases (same as chrome): "Rest element must be last element" This makes the code a little bit simpler
  • Rename parseRest() to parseRestBinding()
danez added 2 commits Feb 27, 2019
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 28, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10340/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Feb 28, 2019

  • Parse RestElement in parseObjectMember not with parseRest() as only Identifier is allowed in this context
  • Disallow a newline between async and method name.

Could you add some tests for these two points? (Unless I just missed them)

danez added 3 commits Feb 28, 2019
@danez

This comment has been minimized.

Copy link
Member Author

danez commented Feb 28, 2019

I added a test for the async-newline stuff. The RestElement has already tests. It is all the tests that switched from throwing Invalid rest operator's argument to Unexpected token.

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Feb 28, 2019
@danez danez merged commit 98ab1b6 into babel:master Feb 28, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.02% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Feb 28, 2019
@danez danez deleted the danez:refactor-obj branch Feb 28, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.