Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check for-in and for-of loop for invalid left-hand side #9768

Merged
merged 2 commits into from Mar 26, 2019

Conversation

@danez
Copy link
Member

commented Mar 25, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

We were allowing assignments in for-in loops

var x; for(x = 3 in list);

which is not allowed. The only exception is for(var x = 1 in list); in non-strict mode.

I refactored this checks and moved them into parseForIn(). This also improves the error messages.

Tests were already present

also did the same in acorn: acornjs/acorn#821

@danez danez added this to In progress in Parser: Spec Compliance, Refactoring and Performance via automation Mar 25, 2019
@danez danez force-pushed the danez:invalid-for-in branch from 2be32d2 to 97aa8e2 Mar 25, 2019
@danez danez force-pushed the danez:invalid-for-in branch from 97aa8e2 to 787fed9 Mar 25, 2019
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10617/

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Mar 25, 2019
@danez danez merged commit 6bc9e7e into babel:master Mar 26, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.27% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Mar 26, 2019
@danez danez deleted the danez:invalid-for-in branch Mar 26, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.