Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept '\08' or '\09' in strict mode #9769

merged 1 commit into from Apr 2, 2019


Copy link

commented Mar 26, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This comment has been minimized.

Copy link

commented Mar 26, 2019

Build successful! You can test your changes in the REPL here:

this.state.pos += octalStr.length - 1;
const next = this.input.charCodeAt(this.state.pos);
if (
octalStr !== "0" ||

This comment has been minimized.

Copy link

nicolo-ribaudo Mar 26, 2019


This is the same as the previous octal > 0, right? Or is it different in case of \00?

This comment has been minimized.

Copy link

danez Mar 26, 2019

Author Member

Oh right, this is doing exactly the same thing. I copied this part from acorn that's why it changed.

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.