Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept '\08' or '\09' in strict mode #9769

Merged
merged 1 commit into from Apr 2, 2019

Conversation

@danez
Copy link
Member

commented Mar 26, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10618/

this.state.pos += octalStr.length - 1;
const next = this.input.charCodeAt(this.state.pos);
if (
octalStr !== "0" ||

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Mar 26, 2019

Member

This is the same as the previous octal > 0, right? Or is it different in case of \00?

This comment has been minimized.

Copy link
@danez

danez Mar 26, 2019

Author Member

Oh right, this is doing exactly the same thing. I copied this part from acorn that's why it changed.

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Mar 27, 2019
@danez danez merged commit c7587c0 into babel:master Apr 2, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.27% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Apr 2, 2019
@danez danez deleted the danez:ocatl branch Apr 2, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.