Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9232, add some missed modules to `@babel/polyfill/noConflict` #9780

Merged
merged 1 commit into from Apr 2, 2019

Conversation

@zloirock
Copy link
Member

commented Mar 28, 2019

Fixes #9232

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10631/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10631/

@xtuc

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Could we first merge my PR #9808 first, which unifies the normal and noConflict mode. I can rebase this one if needed.

@zloirock

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@xtuc initially, I wanted to do it in this PR. However, since @babel/polyfill is deprecated and too many people use a link to packages/babel-polyfill/src/index.js for show that @babel/polyfill is just core-js and regenerator-runtime import, I decided not to do it.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Well, people can just link packages/babel-polyfill/src/noConflict.js. If you want, we can add a comment in index.js pointing to that file.

@zloirock

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@nicolo-ribaudo I mean existent links.

I don't care.

@xtuc

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Sorry I think i'm missing something. Users that require packages/babel-polyfill/src/index.js will require the noConflict.js + actual conflict code under the hood. I don't think it's breaking exisiting links.

@zloirock

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@xtuc it's about links in the documentation / articles / comments.

@danez
danez approved these changes Apr 2, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 00cae77 into babel:master Apr 2, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.29% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zloirock zloirock deleted the zloirock:fix-9232 branch Apr 3, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.