Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile babel-polyfill to es5, instead of targeting node 6 #9812

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Projects
None yet
5 participants
@nicolo-ribaudo
Copy link
Member

commented Apr 2, 2019

Q                       A
Fixed Issues? Without this PR, BABEL_ENV=production make build-dist throws
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10669/

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10663/

Show resolved Hide resolved babel.config.js Outdated

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:transpile-polyfill-es5 branch from d68057a to b8e4bf6 Apr 4, 2019

@danez

danez approved these changes Apr 9, 2019

@hzoo

hzoo approved these changes Apr 15, 2019

Copy link
Member

left a comment

Did we change this recently or something?

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

We recently introduced some code in @babel/parser which was stranspiled to es6. Previously there was only code which is always transpiled to es5 so we didn't notice it.

@nicolo-ribaudo nicolo-ribaudo merged commit e407275 into babel:master Apr 15, 2019

5 checks passed

babel/repl REPL preview is available
Details
buildsize No prior size to compare - 7.94 MB
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.29% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:transpile-polyfill-es5 branch Apr 15, 2019

@chrisbutler

This comment has been minimized.

Copy link

commented Apr 24, 2019

correct me if i'm wrong, but this is a pretty major regression, no? is there a way to prevent something like this happening again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.