Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PrivateName Identifier should not be isReferenced. #9861

Merged

Conversation

@coreyfarrell
Copy link
Contributor

commented Apr 15, 2019

Q                       A
Fixed Issues? Fixes #9859
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? 👍
Documentation PR Link
Any Dependency Changes?
License MIT

This resolves an exception from @babel/transform-module-commonjs when any kind of class private field is declared with the same name as a named import.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10695/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10695/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.