Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Publish to npm" in the Release workflow #9911

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@nicolo-ribaudo
Copy link
Member

commented Apr 26, 2019

GitHub actions are too slow for this, it takes more than 15 mins.
Publishing to npm from GH actions is a cool idea, but it's a lot faster to
publish locally.

Also, I think that since when I introduced this action I
always killed it; either because it was to slow or because I had to
make some manual tweaks during the release.

The action is still used to commit the changelog and generate the GitHub release.

GitHub actions are too slow for this, it takes more than 15 mins.
Publishing to npm from GH actions is a cool idea, but it's a lot faster to
publish locally.

Also, I think that since when I introduced this action I
always killed it; either because it was to slow or because I had to
make some manual tweaks during the release.
@nicolo-ribaudo nicolo-ribaudo merged commit c5b5c83 into master Apr 26, 2019
1 of 5 checks passed
1 of 5 checks passed
Is version commit Is version commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
On master branch On master branch
Details
ci/circleci Your tests passed on CircleCI!
Details
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10732/

@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo-patch-1 branch Apr 26, 2019
@lock lock bot added the outdated label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.