This repository has been archived by the owner. It is now read-only.

Fix `static` property falling through in `declare class` Flow AST #135

Merged
merged 1 commit into from Sep 21, 2016

Conversation

Projects
None yet
4 participants
@danharper
Copy link
Member

danharper commented Sep 20, 2016

Given the following:

declare class X {
    a: number;
    static b: number;
    c: number;
}

c would get marked as static as it's not being reset between properties.

https://astexplorer.net/#/4Bi9Ce53LA

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 20, 2016

Current coverage is 94.39% (diff: 100%)

Merging #135 into master will increase coverage by <.01%

@@             master       #135   diff @@
==========================================
  Files            19         19          
  Lines          3082       3084     +2   
  Methods         325        325          
  Messages          0          0          
  Branches        806        806          
==========================================
+ Hits           2909       2911     +2   
  Misses           94         94          
  Partials         79         79          

Powered by Codecov. Last update 9cb73d8...2f953de

@hzoo

hzoo approved these changes Sep 21, 2016

@hzoo hzoo merged commit b68918e into babel:master Sep 21, 2016

3 checks passed

codecov/patch 100% of diff hit (target 94.38%)
Details
codecov/project 94.39% (+<.01%) compared to 9cb73d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez

This comment has been minimized.

Copy link
Member

danez commented Sep 21, 2016

Awesome thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.