This repository has been archived by the owner. It is now read-only.

Fix duplicate check #137

Merged
merged 1 commit into from Sep 22, 2016

Conversation

Projects
None yet
5 participants
@danez
Copy link
Member

danez commented Sep 22, 2016

Fix comment in #107

@kaicataldo Can you check if this is correct?

@danez danez added the Tag: Bug Fix label Sep 22, 2016

@@ -123,7 +123,7 @@ export default class State {

// Names of exports store. `default` is stored as a name for both
// `export default foo;` and `export { foo as default };`.
exportedIdentifiers: {[id:string]: boolean};
exportedIdentifiers: Array<string;

This comment has been minimized.

@hzoo

hzoo Sep 22, 2016

Member

Array<string>;

This comment has been minimized.

@danez

danez Sep 22, 2016

Author Member

👍 Done

@danez danez force-pushed the danez:fix-default branch from 6c94634 to 992320e Sep 22, 2016

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Sep 22, 2016

cc @dlmr

@kaicataldo
Copy link
Member

kaicataldo left a comment

LGTM. Thanks for fixing this!

@dlmr

This comment has been minimized.

Copy link

dlmr commented Sep 22, 2016

Looks good! LGTM 👍

@hzoo hzoo merged commit 952d50f into babel:master Sep 22, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@danez danez deleted the danez:fix-default branch Sep 22, 2016

@@ -43,7 +43,7 @@ export default class State {
this.containsEsc = this.containsOctal = false;
this.octalPosition = null;

this.exportedIdentifiers = {};
this.exportedIdentifiers = [];

This comment has been minimized.

@STRML

STRML Sep 22, 2016

Any reason to not use Object.create(null); here instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.