This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix duplicate check #137
Conversation
danez
added
the
Tag: Bug Fix
label
Sep 22, 2016
hzoo
reviewed
Sep 22, 2016
src/tokenizer/state.js
Outdated
| @@ -123,7 +123,7 @@ export default class State { | |||
|
|
|||
| // Names of exports store. `default` is stored as a name for both | |||
| // `export default foo;` and `export { foo as default };`. | |||
| exportedIdentifiers: {[id:string]: boolean}; | |||
| exportedIdentifiers: Array<string; | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danez
force-pushed the
danez:fix-default
branch
from
6c94634
to
992320e
Sep 22, 2016
This comment has been minimized.
This comment has been minimized.
|
cc @dlmr |
This comment has been minimized.
This comment has been minimized.
dlmr
commented
Sep 22, 2016
|
Looks good! LGTM |
hzoo
merged commit 952d50f
into
babel:master
Sep 22, 2016
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
danez
deleted the
danez:fix-default
branch
Sep 22, 2016
STRML
reviewed
Sep 22, 2016
| @@ -43,7 +43,7 @@ export default class State { | |||
| this.containsEsc = this.containsOctal = false; | |||
| this.octalPosition = null; | |||
|
|
|||
| this.exportedIdentifiers = {}; | |||
| this.exportedIdentifiers = []; | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danez commentedSep 22, 2016
•
edited
Fix comment in #107
@kaicataldo Can you check if this is correct?