This repository has been archived by the owner. It is now read-only.

Allow keywords in object/class property names with Flow type parameters #145

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Projects
None yet
3 participants
@danharper
Copy link
Member

danharper commented Sep 26, 2016

For #48

Certain keywords like delete, yield, do set beforeExpr: true. These update exprAllowed in state. Ultimately, it results in the JSX plugin picking up the < token due to exprAllowed.

This fix prevents the JSX plugin from reading tokens in property names, allowing the Flow plugin to pick them up instead.

@danharper danharper force-pushed the danharper:fix48-js branch from cff218d to 5f655e6 Sep 26, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 26, 2016

Current coverage is 94.48% (diff: 100%)

Merging #145 into master will increase coverage by 0.01%

@@             master       #145   diff @@
==========================================
  Files            19         19          
  Lines          3111       3118     +7   
  Methods         327        329     +2   
  Messages          0          0          
  Branches        818        818          
==========================================
+ Hits           2939       2946     +7   
  Misses           94         94          
  Partials         78         78          

Powered by Codecov. Last update 4115bcb...5f655e6

@danez

danez approved these changes Oct 14, 2016

@danez danez merged commit f7c1af1 into babel:master Oct 14, 2016

3 checks passed

codecov/patch 100% of diff hit (target 94.47%)
Details
codecov/project 94.48% (+0.01%) compared to 4115bcb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.