This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow keywords in object/class property names with Flow type parameters #145
Conversation
danharper
referenced this pull request
Sep 26, 2016
Merged
Allow keywords in Flow object property names with type parameters #146
danharper
force-pushed the
danharper:fix48-js
branch
from
cff218d
to
5f655e6
Sep 26, 2016
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Sep 26, 2016
•
Current coverage is 94.48% (diff: 100%)@@ master #145 diff @@
==========================================
Files 19 19
Lines 3111 3118 +7
Methods 327 329 +2
Messages 0 0
Branches 818 818
==========================================
+ Hits 2939 2946 +7
Misses 94 94
Partials 78 78
|
danez
added
Tag: Bug Fix
area: flow
labels
Sep 26, 2016
danez
approved these changes
Oct 14, 2016
danez
merged commit f7c1af1
into
babel:master
Oct 14, 2016
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danharper commentedSep 26, 2016
For #48
Certain keywords like
delete,yield,dosetbeforeExpr: true. These updateexprAllowedin state. Ultimately, it results in the JSX plugin picking up the<token due toexprAllowed.This fix prevents the JSX plugin from reading tokens in property names, allowing the Flow plugin to pick them up instead.