This repository has been archived by the owner. It is now read-only.

Raise error on duplicate definition of __proto__ #183

Merged
merged 1 commit into from Oct 16, 2016

Conversation

Projects
None yet
3 participants
@motiz88
Copy link
Contributor

motiz88 commented Oct 15, 2016

Spec: http://www.ecma-international.org/ecma-262/6.0/#sec-__proto__-property-names-in-object-initializers

This brings back to life a bit of dead code in Parser.prototype.checkPropClash, and enables several tests that were previously disabled.

Raise error on duplicate definition of __proto__
Spec: http://www.ecma-international.org/ecma-262/6.0/#sec-__proto__-property-names-in-object-initializers

This brings back to life a bit of dead code in Parser.prototype.checkPropClash, and enables several tests that were previously disabled.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 15, 2016

Current coverage is 94.66% (diff: 100%)

Merging #183 into master will increase coverage by 0.09%

@@             master       #183   diff @@
==========================================
  Files            19         19          
  Lines          3189       3189          
  Methods         333        333          
  Messages          0          0          
  Branches        839        839          
==========================================
+ Hits           3016       3019     +3   
+ Misses           94         92     -2   
+ Partials         79         78     -1   

Powered by Codecov. Last update 394c954...a16b8a4

@danez danez removed the i: bug label Oct 16, 2016

@danez

danez approved these changes Oct 16, 2016

@danez danez merged commit 9b6e243 into babel:master Oct 16, 2016

3 checks passed

codecov/patch 100% of diff hit (target 94.57%)
Details
codecov/project 94.66% (+0.09%) compared to 394c954
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016

Raise error on duplicate definition of __proto__ (babel#183)
Spec: http://www.ecma-international.org/ecma-262/6.0/#sec-__proto__-property-names-in-object-initializers

This brings back to life a bit of dead code in Parser.prototype.checkPropClash, and enables several tests that were previously disabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.