This repository has been archived by the owner. It is now read-only.

Allow "async" as identifier for object literal property shorthand #187

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
5 participants
@DrewML
Copy link
Member

DrewML commented Oct 16, 2016

Closes #186

@DrewML DrewML force-pushed the DrewML:issue186 branch from 9ad9f97 to b52561b Oct 16, 2016

@danharper

This comment has been minimized.

Copy link
Member

danharper commented Oct 16, 2016

👍 but the test case should include a trailing comma, right?

@danez danez added the Tag: Bug Fix label Oct 16, 2016

@DrewML DrewML force-pushed the DrewML:issue186 branch from b52561b to 2e23b62 Oct 16, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2016

Current coverage is 96.15% (diff: 100%)

Merging #187 into master will not change coverage

@@             master       #187   diff @@
==========================================
  Files            19         19          
  Lines          3169       3169          
  Methods         333        333          
  Messages          0          0          
  Branches        832        832          
==========================================
  Hits           3047       3047          
  Misses           63         63          
  Partials         59         59          

Powered by Codecov. Last update 9b6e243...2e23b62

@DrewML

This comment has been minimized.

Copy link
Member Author

DrewML commented Oct 16, 2016

👍 but the test case should include a trailing comma, right?

LOL. I love that I had a test case in the issue and I still made this mistake. Good catch 👍.

I've pushed an update

@hzoo hzoo merged commit 01e984f into babel:master Oct 17, 2016

3 checks passed

codecov/patch 100% of diff hit (target 96.15%)
Details
codecov/project 96.15% (+0.00%) compared to 9b6e243
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.