This repository has been archived by the owner. It is now read-only.

Error on missing expected.json fixture in CI #188

Merged
merged 1 commit into from Oct 16, 2016

Conversation

Projects
None yet
3 participants
@motiz88
Copy link
Contributor

motiz88 commented Oct 16, 2016

This blocks (in a CI environment) the default behavior of automatically creating missing expected.json files, thereby guarding against silent failure (and a potential false positive) if a test is accidentally committed without its expected.json.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2016

Current coverage is 94.57% (diff: 100%)

Merging #188 into master will not change coverage

@@             master       #188   diff @@
==========================================
  Files            19         19          
  Lines          3189       3189          
  Methods         333        333          
  Messages          0          0          
  Branches        839        839          
==========================================
  Hits           3016       3016          
  Misses           94         94          
  Partials         79         79          

Powered by Codecov. Last update 394c954...dd06893

motiz88 added a commit to motiz88/babel that referenced this pull request Oct 16, 2016

Automatically generate missing expected.js fixtures
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Oct 16, 2016

So good!!

@hzoo hzoo merged commit 490ae9a into babel:master Oct 16, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 394c954...dd06893
Details
codecov/project 94.57% (+0.00%) compared to 394c954
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

danez added a commit to babel/babel that referenced this pull request Oct 17, 2016

Automatically generate missing expected.js fixtures (#4735)
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.

chrisprice added a commit to chrisprice/babel that referenced this pull request Oct 18, 2016

Automatically generate missing expected.js fixtures (babel#4735)
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.

kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Automatically generate missing expected.js fixtures (babel#4735)
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.