This repository has been archived by the owner. It is now read-only.

Fix strange line endings #214

Merged
merged 1 commit into from Nov 9, 2016

Conversation

Projects
None yet
3 participants
@graingert
Copy link
Contributor

graingert commented Nov 8, 2016

There seems to be some strange line endings that's causing my git
to freak out.

Q A
Bug fix? yes/no
Breaking change? yes/no
New feature? yes/no
Deprecations? yes/no
Spec compliancy? yes/no
Tests added/pass? yes/no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
@graingert

This comment has been minimized.

Copy link
Contributor Author

graingert commented Nov 8, 2016

I'm sure these files are intentional, but my git automatically does CRLF changes on them

@graingert

This comment has been minimized.

Copy link
Contributor Author

graingert commented Nov 8, 2016

warning: CRLF will be replaced by LF in test/fixtures/core/uncategorised/100/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/core/uncategorised/437/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/core/uncategorised/439/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/core/uncategorised/443/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/core/uncategorised/50/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/es2015/uncategorised/22/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/es2015/uncategorised/23/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/esprima/expression-primary/literal/string/migrated_0017.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/esprima/invalid-syntax/migrated_0155/actual.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/fixtures/esprima/invalid-syntax/migrated_0159/actual.js.
The file will have its original line endings in your working directory.
@graingert

This comment has been minimized.

Copy link
Contributor Author

graingert commented Nov 8, 2016

I suspect it would be better to exclude these files in:

* text eol=lf

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 8, 2016

Current coverage is 96.21% (diff: 100%)

Merging #214 into master will not change coverage

@@             master       #214   diff @@
==========================================
  Files            19         19          
  Lines          3167       3167          
  Methods         333        333          
  Messages          0          0          
  Branches        831        831          
==========================================
  Hits           3047       3047          
  Misses           62         62          
  Partials         58         58          

Powered by Codecov. Last update 4141683...dd4aa77

@danez danez merged commit e05bbee into babel:master Nov 9, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 4141683...dd4aa77
Details
codecov/project 96.21% (+0.00%) compared to 4141683
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez

This comment has been minimized.

Copy link
Member

danez commented Nov 9, 2016

Thanks

@graingert graingert deleted the graingert:fix-line-endings branch Nov 9, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.