Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add watch script for dev #234
The watch script was removed in this PR when we started bundling Babylon with rollup (which is awesome!). This PR sets up a watch script for us (the big difference is that with Rollup the
I tried Rollup's watcher, but it is currently WIP, and would crash and was unable to recover from saving files with syntax errors when I tried it.
This is more of a stop gap measure until the Rollup watcher is ready for primetime.
Thoughts on this? I personally was using the watcher and have continued to set up something like this up locally when I'm working on Babylon, so figured it might be nice to have a watch script again. Totally understand we probably want to use one of the two solutions above, but I figured having a watcher is better than not :)
2 times, most recently
Nov 24, 2016
It would be nice in general that the tests maybe not use the rollup bundle, so that we can have proper unit tests, right now the only thing that can be tested is the public API.
I think the only part that would be concerning is not running any tests against the bundle in CI. It's possible
Edit: Thinking about it more, we run the
Yeah! Seems like we could run that CI test against the bundle?
Could it make sense to split this out into unit and integration/behavioral tests and not bundle for the first and then bundle for the latter?
Maybe it would make more sense to separate these two tasks out? I don't think these two things have to be tied together. Seems like we could just do the watcher script in this one and we then have the env's to take it further for testing, etc. in a future PR? My intention with this was just to add a convenience for us devs :)