This repository has been archived by the owner. It is now read-only.

flow: allow leading pipes in all positions #256

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
3 participants
@vkurchatkin
Copy link
Contributor

vkurchatkin commented Dec 13, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

/cc @jeffmo

@danez

This comment has been minimized.

Copy link
Member

danez commented Dec 14, 2016

Is that a new change in flow? OR was that wrong in babylon?
Anyway if it should be really allowed everywhere a type can appear, then this looks good to me.

@danez danez added the area: flow label Dec 14, 2016

@vkurchatkin

This comment has been minimized.

Copy link
Contributor Author

vkurchatkin commented Dec 14, 2016

I don't think it's new and have no idea why it wasn't implemented like this in the first place. I hope @jeffmo could clarify.

I've tested all examples with Flow and they work fine.

@vkurchatkin

This comment has been minimized.

Copy link
Contributor Author

vkurchatkin commented Dec 14, 2016

I've taken a look at Flow's source code and that's exactly what they do

@jeffmo

This comment has been minimized.

Copy link
Contributor

jeffmo commented Dec 24, 2016

Sorry for the delay -- it was extended to any type annotation (rather than just aliases) back in v0.31.
A quick look at the tests here seem legit

@danez

danez approved these changes Dec 24, 2016

@danez danez merged commit 3dc4039 into babel:master Jan 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.