Skip to content
This repository has been archived by the owner. It is now read-only.

[7.0] Throw on trailing comma with rest-spread #290

Merged
merged 1 commit into from Jan 16, 2017
Merged

Conversation

@danez
Copy link
Member

@danez danez commented Jan 12, 2017

Q A
Bug fix? yes
Breaking change? yes
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

This reverts commit 5bac6e8. #154

Fixes babel/babel#5092

@danez danez added this to the 7.0.0 milestone Jan 12, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 12, 2017

Current coverage is 97.46% (diff: 99.36%)

Merging #290 into 7.0 will decrease coverage by 0.11%

@@                7.0       #290   diff @@
==========================================
  Files            20         21     +1   
  Lines          3967       3991    +24   
  Methods         469        491    +22   
  Messages          0          0          
  Branches       1175       1164    -11   
==========================================
+ Hits           3871       3890    +19   
- Misses           42         44     +2   
- Partials         54         57     +3   

Powered by Codecov. Last update ed625cb...6a19abe

@danez danez changed the base branch from master to 7.0 Jan 12, 2017
@danez danez force-pushed the throw-semi-after-rest branch from 6a19abe to 954b7f5 Jan 12, 2017
@danez danez force-pushed the throw-semi-after-rest branch from 954b7f5 to d24e3bb Jan 12, 2017
@danez
Copy link
Member Author

@danez danez commented Jan 16, 2017

Seems travis is confused and still tests 0.10 and 0.12 in this PR although base is 7.0

@danez danez merged commit bd00176 into 7.0 Jan 16, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@danez danez deleted the throw-semi-after-rest branch Jan 16, 2017
@loganfsmyth
Copy link
Member

@loganfsmyth loganfsmyth commented Feb 21, 2017

(Edit) Nevermind, my test case was wrong :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.