This repository has been archived by the owner. It is now read-only.

[7.0] Throw on trailing comma with rest-spread #290

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
3 participants
@danez
Member

danez commented Jan 12, 2017

Q A
Bug fix? yes
Breaking change? yes
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

This reverts commit 5bac6e8. #154

Fixes babel/babel#5092

@danez danez added this to the 7.0.0 milestone Jan 12, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 12, 2017

Current coverage is 97.46% (diff: 99.36%)

Merging #290 into 7.0 will decrease coverage by 0.11%

@@                7.0       #290   diff @@
==========================================
  Files            20         21     +1   
  Lines          3967       3991    +24   
  Methods         469        491    +22   
  Messages          0          0          
  Branches       1175       1164    -11   
==========================================
+ Hits           3871       3890    +19   
- Misses           42         44     +2   
- Partials         54         57     +3   

Powered by Codecov. Last update ed625cb...6a19abe

codecov-io commented Jan 12, 2017

Current coverage is 97.46% (diff: 99.36%)

Merging #290 into 7.0 will decrease coverage by 0.11%

@@                7.0       #290   diff @@
==========================================
  Files            20         21     +1   
  Lines          3967       3991    +24   
  Methods         469        491    +22   
  Messages          0          0          
  Branches       1175       1164    -11   
==========================================
+ Hits           3871       3890    +19   
- Misses           42         44     +2   
- Partials         54         57     +3   

Powered by Codecov. Last update ed625cb...6a19abe

@danez danez changed the base branch from master to 7.0 Jan 12, 2017

@danez

This comment has been minimized.

Show comment
Hide comment
@danez

danez Jan 16, 2017

Member

Seems travis is confused and still tests 0.10 and 0.12 in this PR although base is 7.0

Member

danez commented Jan 16, 2017

Seems travis is confused and still tests 0.10 and 0.12 in this PR although base is 7.0

@danez danez merged commit bd00176 into 7.0 Jan 16, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@danez danez deleted the throw-semi-after-rest branch Jan 16, 2017

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Feb 21, 2017

Member

(Edit) Nevermind, my test case was wrong :P

Member

loganfsmyth commented Feb 21, 2017

(Edit) Nevermind, my test case was wrong :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.