This repository has been archived by the owner. It is now read-only.

Do not allow overwritting of primitive types #314

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
3 participants
@danez
Copy link
Member

danez commented Jan 18, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

I noticed that flow does not allow overwriting of primitive types. http://astexplorer.net/#/AVDxqdz5yq

This also adds this behaviour to babylon.

/cc @samwgoldman @gabelevi @jeffmo

Daniel Tschinder
@xtuc

xtuc approved these changes Jan 18, 2017

Copy link
Member

xtuc left a comment

👍

Daniel Tschinder
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 18, 2017

Current coverage is 97.27% (diff: 100%)

Merging #314 into master will increase coverage by <.01%

@@             master       #314   diff @@
==========================================
  Files            21         21          
  Lines          4001       4006     +5   
  Methods         485        482     -3   
  Messages          0          0          
  Branches       1179       1184     +5   
==========================================
+ Hits           3892       3897     +5   
  Misses           49         49          
  Partials         60         60          

Powered by Codecov. Last update 1150c0d...805bd1e

@danez danez merged commit 0a00aff into master Jan 20, 2017

4 checks passed

codecov/patch 100% of diff hit (target 97.27%)
Details
codecov/project 97.27% (+<.01%) compared to 1150c0d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the disallow-primitives branch Jan 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.