This repository has been archived by the owner. It is now read-only.

Allow imports in declare module #315

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
3 participants
@danez
Copy link
Member

danez commented Jan 18, 2017

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

This allows import type or import typeof inside declare module.
This was done in flow in this commit: facebook/flow@843389f

//cc @jeffmo

Daniel Tschinder
Daniel Tschinder

@danez danez changed the title Allow imports in declare module {} Allow imports in declare module Jan 18, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 18, 2017

Current coverage is 97.27% (diff: 100%)

Merging #315 into master will increase coverage by <.01%

@@             master       #315   diff @@
==========================================
  Files            21         21          
  Lines          4001       4007     +6   
  Methods         481        486     +5   
  Messages          0          0          
  Branches       1183       1180     -3   
==========================================
+ Hits           3892       3898     +6   
  Misses           49         49          
  Partials         60         60          

Powered by Codecov. Last update a1bfa02...44a804e

@jeffmo

This comment has been minimized.

Copy link
Contributor

jeffmo commented Jan 18, 2017

@danez danez merged commit d5cd2c3 into master Jan 20, 2017

4 checks passed

codecov/patch 100% of diff hit (target 97.27%)
Details
codecov/project 97.27% (+<.01%) compared to a1bfa02
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the allow-import-in-declare branch Jan 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.