This repository has been archived by the owner. It is now read-only.

Fix #321 by allowing question marks in type params #338

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@danez
Copy link
Member

danez commented Jan 31, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets Fixes #321
License MIT

This reverses the logic of the loop inside flowParseFunctionTypeParams, which does not only allow name tokens but any token besides parenR and ellipsis.

//cc @gabelevi

Daniel Tschinder
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #338 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   97.65%   97.65%   +<.01%     
==========================================
  Files          20       20              
  Lines        3326     3327       +1     
  Branches      882      883       +1     
==========================================
+ Hits         3248     3249       +1     
  Misses         30       30              
  Partials       48       48
Impacted Files Coverage Δ
src/plugins/flow.js 97.53% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c4a7...209ae11. Read the comment docs.

Daniel Tschinder

@danez danez merged commit 407c97c into master Feb 10, 2017

4 checks passed

codecov/patch 100% of diff hit (target 97.65%)
Details
codecov/project 97.65% (+<.01%) compared to 898c4a7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the fix-321 branch Feb 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.