This repository has been archived by the owner. It is now read-only.

Correctly convert RestProperty to Assignable #339

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@danez
Copy link
Member

danez commented Jan 31, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets Fixes #304 Fixes #309
License MIT

if the parsed spread is inside of an ObjectPattern we need to convert it to an assignable (ObjectExpression->ObjectPattern).
Also when parsing the spread inside a ObjectPattern we need to allow shorthand properties.

@danez danez added the Tag: Bug Fix label Jan 31, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@407c97c). Click here to learn what that means.

@@            Coverage Diff            @@
##             master     #339   +/-   ##
=========================================
  Coverage          ?   97.65%           
=========================================
  Files             ?       20           
  Lines             ?     3327           
  Branches          ?      884           
=========================================
  Hits              ?     3249           
  Misses            ?       30           
  Partials          ?       48
Impacted Files Coverage Δ
src/parser/expression.js 97.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407c97c...7cb21c5. Read the comment docs.

Daniel Tschinder

@danez danez force-pushed the fix-destruct branch from e907da6 to 7cb21c5 Feb 10, 2017

@danez danez merged commit c79dd95 into master Feb 10, 2017

4 checks passed

codecov/patch 100% of diff hit (target 97.74%)
Details
codecov/project 97.74% (+<.01%) compared to 407c97c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the fix-destruct branch Feb 10, 2017

@hzoo hzoo referenced this pull request May 22, 2017

Merged

Babylon 7 alpha.10 #5761

7 of 8 tasks complete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.