This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure takeDecorators is called on exported class #358
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 12, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=========================================
Coverage ? 97.85%
=========================================
Files ? 21
Lines ? 3504
Branches ? 925
=========================================
Hits ? 3429
Misses ? 28
Partials ? 47
Continue to review full report at Codecov.
|
existentialism
changed the title
Ensure takeDecorators is called on export class
Ensure takeDecorators is called on exported class
Feb 12, 2017
existentialism
force-pushed the
issue259
branch
from
14d6cdc
to
89dc160
Feb 12, 2017
existentialism
added
the
Tag: Bug Fix
label
Feb 13, 2017
danez
merged commit ad8d520
into
master
Feb 22, 2017
danez
deleted the
issue259
branch
Feb 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
existentialism commentedFeb 12, 2017
Looks like
takeDecorators
wasn't being called on an exported class, so this ensures it is called in both cases.