This repository has been archived by the owner. It is now read-only.

Ensure takeDecorators is called on exported class #358

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
3 participants
@existentialism
Copy link
Member

existentialism commented Feb 12, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes/yes
Fixed tickets Fixes #259
License MIT

Looks like takeDecorators wasn't being called on an exported class, so this ensures it is called in both cases.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 12, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@57aacea). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #358   +/-   ##
=========================================
  Coverage          ?   97.85%           
=========================================
  Files             ?       21           
  Lines             ?     3504           
  Branches          ?      925           
=========================================
  Hits              ?     3429           
  Misses            ?       28           
  Partials          ?       47
Impacted Files Coverage Δ
src/parser/statement.js 98.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aacea...89dc160. Read the comment docs.

@existentialism existentialism changed the title Ensure takeDecorators is called on export class Ensure takeDecorators is called on exported class Feb 12, 2017

@danez danez merged commit ad8d520 into master Feb 22, 2017

3 checks passed

codecov/patch 100% of diff hit (target 97.85%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the issue259 branch Feb 22, 2017

@hzoo hzoo referenced this pull request May 22, 2017

Merged

Babylon 7 alpha.10 #5761

7 of 8 tasks complete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.