This repository has been archived by the owner. It is now read-only.

Fix generator-method-with-computed-name test #360

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
3 participants
@rattrayalex
Copy link
Contributor

rattrayalex commented Feb 15, 2017

Q A
Bug fix? yes (test fix)
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? not sure
Tests added/pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

This test was previously checking that a block does not parse as an object, though the intent appeared to be to validate that you can have [yield iter] be the key of an object.

I'm not sure if this is compliant with the spec, or if it makes any sense. If this is indeed supposed to raise an error, I'd be happy to try to submit a patch fixing the parser.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 15, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@57aacea). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #360   +/-   ##
========================================
  Coverage          ?   97.8%           
========================================
  Files             ?      21           
  Lines             ?    3504           
  Branches          ?     925           
========================================
  Hits              ?    3427           
  Misses            ?      29           
  Partials          ?      48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aacea...4a58492. Read the comment docs.

rattrayalex added a commit to lightscript/babylon-lightscript that referenced this pull request Feb 15, 2017

rattrayalex added a commit to lightscript/babylon-lightscript that referenced this pull request Feb 18, 2017

@danez

This comment has been minimized.

Copy link
Member

danez commented Feb 22, 2017

All parsers seem to parse this correctly so I assume this is correct.

@danez danez merged commit 94eda12 into babel:master Feb 22, 2017

2 of 3 checks passed

codecov/project No report found to compare against
Details
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rattrayalex added a commit to lightscript/babylon-lightscript that referenced this pull request Mar 1, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.