Skip to content
This repository has been archived by the owner. It is now read-only.

Remove private field shorthand #648

Merged
merged 1 commit into from Jul 27, 2017

Conversation

@Qantas94Heavy
Copy link
Member

Qantas94Heavy commented Jul 25, 2017

Q A
Bug fix? yes
Breaking change? yes
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

There seems to be tentative agreement to remove the private field
shorthand given the added confusion and edge cases involved with the
shorthand.

Refs: tc39/proposal-class-fields#21


This will change the expected error message for the ASI generator test, given that #x would no longer be a valid expression, which means the error will be thrown there instead.

There seems to be tentative agreement to remove the private field
shorthand given the added confusion and edge cases involved with the
shorthand.

Refs: tc39/proposal-class-fields#21
@bakkot
bakkot approved these changes Jul 27, 2017
@jridgewell jridgewell merged commit 6821cfb into babel:master Jul 27, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 96.02%)
Details
codecov/project 96.05% (+0.03%) compared to 59ffa62
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@littledan

This comment has been minimized.

Copy link

littledan commented Jul 27, 2017

Note that there is a possible follow-on proposal to reintroduce the shorthand at https://github.com/littledan/proposal-private-shorthand

@hzoo hzoo referenced this pull request Aug 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.