New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature detection bug for setupPreprocessorRegistry. #106

Merged
merged 2 commits into from Dec 7, 2016

Conversation

Projects
None yet
2 participants
@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2016

The logic here was incorrect for beta versions of ember-cli (due to bizarreness in how semver package deals with prereleases).

This fixes the issue.

rwjblue added some commits Dec 7, 2016

Fix feature detection bug for setupPreprocessorRegistry.
The logic here was incorrect for beta versions of ember-cli (due to bizarreness in how `semver` package deals with prereleases).

This fixes the issue.

@rwjblue rwjblue merged commit df1689b into master Dec 7, 2016

1 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rwjblue rwjblue deleted the WAT!!!!!! branch Dec 7, 2016

@Turbo87

This comment has been minimized.

Copy link
Contributor

Turbo87 commented Dec 8, 2016

@rwjblue the issue here was actually that I moved from the deprecated version checker functions to using checker.for('ember-cli', 'npm'), which behaves differently. To be precise the NPM-based checker includes the prerelease stuff, while the deprecated CLI checker doesn't (see https://github.com/ember-cli/ember-cli-version-checker/blob/master/src/ember-cli-dependency-version-checker.js#L12-L13)

@Turbo87 Turbo87 added the bug label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment