New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel 6 #115

merged 44 commits into from Mar 13, 2017


None yet
3 participants
Copy link

rwjblue commented Mar 12, 2017

No description provided.

rwjblue added some commits Dec 8, 2016

Implement `project.targets` awareness.
When `this.project.targets` is present, use `babel-preset-env`
providing the `project.targets.browser` value as the config.

When `this.project.targets` is not present, use `babel-preset-latest`
to ensure all transpilation is done.
Use custom modules transform build.
This is a custom published fork of babel-plugin-transform-es2015-modules-amd
with the changes from babel/babel#5422 (which fixes
an issue with interop between babel@5 and babel@6 modules).

This commit should be revertted once a version of babel@6 is released that
includes those changes.
Add `baseDir` to all internally added plugins.
`baseDir` is used in caching system inside broccoli-babel-transpiler.
Expose `isPluginRequired` helper method.
This will allow things a bit of an easier time to know
if they should or should not include things.

e.g. `ember-maybe-import-regenerator` can detect that `transform-regenerator`
is not needed, and noop itself.
Add custom work around for ember-cli < 2.13 to avoid interop errors.
When included in a top level (app directly or addon during addon dev)
mutating the main `options.babel.plugins` results in incompatibilities
because ember-cli itself uses the top levels babel options to control
how it transpiles things _internally_ (e.g. addon modules).
The issue here is that ember-cli will be using babel@5 so adding babel@6
style plugins will cause errors.

This adds some annoying coupling in ember-cli-babel, but `options.babel6`
seems "ok" anyways, and is only in constrained "legacy" circumstances...

@rwjblue rwjblue requested review from stefanpenner and Turbo87 Mar 12, 2017

@rwjblue rwjblue referenced this pull request Mar 12, 2017


Use Babel 6 #6828

0 of 2 tasks complete

rwjblue added some commits Mar 12, 2017

Update to broccoli-babel-transpiler@6.0.0.
Final version released, update to stable.

@rwjblue rwjblue force-pushed the babel-6 branch from 3b9039c to 82fb0ea Mar 12, 2017

rwjblue added some commits Mar 12, 2017

Increase timeout when requiring into babel-preset-env.
The first babel-preset-env call causes a timeout (2000ms) on
AppVeyor.  Increasing timeout to get things passing.

@rwjblue rwjblue force-pushed the babel-6 branch from cb46e73 to 824a961 Mar 12, 2017

cibernox and others added some commits Mar 13, 2017

Merge pull request #116 from cibernox/remove-temporary-fork
Remove temporary fork after babel release

@rwjblue rwjblue merged commit f9c4694 into master Mar 13, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@rwjblue rwjblue deleted the babel-6 branch Mar 13, 2017

@rwjblue rwjblue referenced this pull request Mar 13, 2017


Babel 6.0 #62

homu added a commit to ember-cli/ember-cli that referenced this pull request Mar 13, 2017

Auto merge of #6828 - ember-cli:babel-6-internally, r=rwjblue
Use Babel 6

This is the starting point for using babel@6 in ember-cli itself and apps. This mostly includes various fallback paths that we have provided that ensure "things are transpiled", without much guarantee about actual transpilation content.

It also paves the way for allowing the usage of ember-cli-babel@6 by providing `this.options.babel` as needed based on ember-cli-babel version in use.

Utilizes the new `project.targets` to provide custom transpilation configuration based on project targets.


- [ ] Release final stable version of ember-cli-babel@6 (babel/ember-cli-babel#115)
- [ ] Release final stable version of ember-cli-htmlbars-inline-precompile for babel@6 support

Fixes #5015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment