New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly forward the browsers targets to ember-preset-env #122

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
4 participants
@kanongil
Copy link
Contributor

kanongil commented Mar 21, 2017

Currently they are completely ignored.

@cibernox

This comment has been minimized.

Copy link
Contributor

cibernox commented Mar 21, 2017

I just wonder if we can create a test harness that ember-cli-babel honour targets.

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Mar 21, 2017

@kanongil - How embarrassing, thank you for digging and submitting the fix!

@cibernox - Ya, we have a bunch of node-tests already, I'll add one to confirm preset env is generally working (pass a specific set of targets and confirm various plugins are not used).

@rwjblue rwjblue merged commit 60d12de into babel:master Mar 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Turbo87 Turbo87 added the bug label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment