New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade all the deps #144

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
3 participants
@stefanpenner
Copy link
Member

stefanpenner commented May 15, 2017

No description provided.

@stefanpenner stefanpenner requested a review from rwjblue May 15, 2017

.travis.yml Outdated
- npm test
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup

This comment has been minimized.

@rwjblue

rwjblue May 16, 2017

Member

I believe this will result in us not actually running the node tests?

.travis.yml Outdated

env:
# we recommend testing LTS's and latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-lts-2.4

This comment has been minimized.

@rwjblue

rwjblue May 16, 2017

Member

There is no ember specific code here, I don't think we need to test more than one (slowing down CI runs...)

.travis.yml Outdated
- "6"
- "7"

This comment has been minimized.

@rwjblue

rwjblue May 16, 2017

Member

We need to continue to test against 4, 6, and 7.

This comment has been minimized.

@stefanpenner

stefanpenner May 16, 2017

Author Member

Oops

@stefanpenner

This comment has been minimized.

Copy link
Member Author

stefanpenner commented May 16, 2017

@rwjblue thanks for the review, should be addressed now!

@rwjblue rwjblue merged commit 65038c7 into master May 16, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@stefanpenner stefanpenner deleted the update branch May 31, 2017

@Turbo87 Turbo87 added the internal label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment