New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES #150] update babel-preset-env #152

Merged
merged 2 commits into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@stefanpenner
Copy link
Member

stefanpenner commented May 31, 2017

No description provided.

@stefanpenner stefanpenner requested a review from rwjblue May 31, 2017

index.js Outdated
@@ -225,7 +225,7 @@ module.exports = {
let browsers = targets && targets.browsers;
let presetOptions = Object.assign({}, options, {
modules: false,
targets: { browsers },
targets: targets

This comment has been minimized.

@rwjblue

rwjblue May 31, 2017

Member

Can probably just use shorthand since the names are the same

This comment has been minimized.

@stefanpenner

stefanpenner May 31, 2017

Author Member

does that work in node 4?

This comment has been minimized.

@stefanpenner

stefanpenner May 31, 2017

Author Member

yup

@stefanpenner stefanpenner force-pushed the babel-preset-env branch from ad1e76b to 9ccd3a4 May 31, 2017

Disable mocha timeouts.
Adding the require for targets-parser from within babel-preset-env
pushed us over the budget previously set. This removes timeouts for
the first tests that do these requires (bumping the timeout value
everytime requiring the giant JSON files babel-preset-env contains
is very annoying).

We will still get general build timeouts on CI (after 10 minutes).

@rwjblue rwjblue force-pushed the babel-preset-env branch from 8b443da to a24b01f Jun 1, 2017

@rwjblue rwjblue merged commit 28104d6 into master Jun 1, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rwjblue rwjblue deleted the babel-preset-env branch Jun 1, 2017

@Turbo87 Turbo87 added the internal label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment