New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emberjs/rfcs#176 support by default. #159

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
2 participants
@rwjblue
Copy link
Member

rwjblue commented Jul 3, 2017

This replaces the new modules with globals usage when the Ember version in use does not include its own modules.

As discussed in a recent ember-cli team meeting.

Add emberjs/rfcs#176 support by default.
This replaces the new modules with globals usage when the Ember
version in use does not include its own modules.

As discussed in a recent ember-cli team meeting.
@Turbo87

Turbo87 approved these changes Jul 3, 2017

@Turbo87

This comment has been minimized.

Copy link
Contributor

Turbo87 commented Jul 3, 2017

@rwjblue I suppose we won't backport this to Babel 5, right?

@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Jul 3, 2017

@Turbo87 - I wasn't planning to, but we could if you thought it was required...

@Turbo87

This comment has been minimized.

Copy link
Contributor

Turbo87 commented Jul 3, 2017

likely not necessary since we can mix addons with 5 and 6 in an app and this will create another incentive to update to Babel 6

@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Jul 3, 2017

Sounds good. We also did a bunch of work to make ember-cli-babel@6 work quite a ways back, so folks should not be stuck...

@rwjblue rwjblue merged commit f93f6e2 into babel:master Jul 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue deleted the rwjblue:add-shims-support branch Jul 3, 2017

@Turbo87 Turbo87 referenced this pull request Jul 3, 2017

Closed

Move into future "ember" addon #15

0 of 1 task complete

@Turbo87 Turbo87 added the enhancement label Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment