New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link #194

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
3 participants
@jevanlingen
Copy link
Contributor

jevanlingen commented Nov 21, 2017

"Now that babel-preset-env has stabilized, it has been moved into the main Babel mono-repo."

Fix link
"Now that babel-preset-env has stabilized, it has been moved into the main Babel mono-repo."
@rwjblue
Copy link
Member

rwjblue left a comment

Hehe. “Stabilized” in the message but using “experimental” branch seem at odds with each other...

@jevanlingen

This comment has been minimized.

Copy link
Contributor Author

jevanlingen commented Nov 21, 2017

Yeah that's kinda weird :D.

README.md Outdated
@@ -66,7 +66,7 @@ type BabelPlugin = string | [string, any] | [any, any];
interface EmberCLIBabelConfig {
/**
Configuration options for babel-preset-env.
See https://github.com/babel/babel-preset-env#options for details on these options.
See https://github.com/babel/babel/tree/master/experimental/babel-preset-env#options for details on these options.

This comment has been minimized.

@rwjblue

rwjblue Nov 21, 2017

Member

If we land this as is, the link will be dead once babel-preset-env is moved out of the experimental subfolder.

Can you update this link to instead point at:

https://github.com/babel/babel-preset-env/tree/v1.6.1#options

?

This comment has been minimized.

@jevanlingen

jevanlingen Nov 22, 2017

Author Contributor

Yeah sure!

@rwjblue rwjblue merged commit c2472ca into babel:master Nov 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Nov 22, 2017

Thank you!

@jevanlingen jevanlingen deleted the jevanlingen:patch-1 branch Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment