New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-plugin-ember-modules-api-polyfill to 2.3.0. #197

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@rwjblue
Copy link
Member

rwjblue commented Dec 15, 2017

The primary change here is that imports are lazily accessed where used, instead of creating a variable for the import eagerly.

In practice this doesn't matter very much to folks, but in some circumstances a given import may or may not end up being present (e.g. Ember.Test.registerWaiter). The prior system would throw an error in production builds when import { registerWaiter } from '@ember/test'; was used (due to the mechanism the prior version of the polyfill worked) even if that import was only used in an if (DEBUG) { style guard.

This update fixes that issue...

rwjblue added some commits Dec 15, 2017

Update babel-plugin-ember-modules-api-polyfill to 2.3.0.
The primary change here is that imports are lazily accessed where used,
instead of creating a variable for the import eagerly.

In practice this doesn't matter very much to folks, but in some
circumstances a given import may or may not end up being present (e.g.
`Ember.Test.registerWaiter`). The prior system would throw an error in
production builds when `import { registerWaiter } from '@ember/test';`
was used (due to the mechanism the prior version of the polyfill
worked) even if that import was only used in an `if (DEBUG) {` style
guard.

This update fixes that issue.

@rwjblue rwjblue merged commit 0987183 into babel:master Dec 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue deleted the rwjblue:update-modules-polyfill branch Dec 15, 2017

@Turbo87 Turbo87 added the enhancement label May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment