New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a no-op optimization #204

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
4 participants
@kellyselden
Copy link
Member

kellyselden commented Feb 18, 2018

Closes #201

@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Feb 22, 2018

@kellyselden I like this, but can you add a quick unit test for that hook, ensuring that this works as expected (and continues to into the future)

@kellyselden

This comment has been minimized.

Copy link
Member Author

kellyselden commented Feb 22, 2018

@stefanpenner added a test

@rwjblue
Copy link
Member

rwjblue left a comment

looks good, can you add a test that roughly does:

        subject = this.addon.transpileTree(input.path(), {
          'ember-cli-babel': {
            compileModules: false,
            disablePresetEnv: true,
            disableDebugTooling: true,
            disableEmberModulesAPIPolyfill: true
          }
        });

         expect(subject).to.equal(input.path());
@kellyselden

This comment has been minimized.

Copy link
Member Author

kellyselden commented Feb 22, 2018

@rwjblue That's essentially what my test is. What would you like changed?

@stefanpenner stefanpenner merged commit fd6c9a6 into babel:master Feb 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Feb 27, 2018

released as v6.12.0 🎉

@kellyselden kellyselden deleted the kellyselden:_shouldDoNothing branch Feb 27, 2018

@Turbo87 Turbo87 added the enhancement label May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment