New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update babel-plugin-debug-macros to 0.2.0-beta.6 #230

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@kellyselden
Copy link
Member

kellyselden commented Jul 11, 2018

@kellyselden kellyselden requested a review from rwjblue Jul 11, 2018

@kellyselden kellyselden force-pushed the kellyselden:babel-plugin-debug-macros branch from a485df6 to 237ca23 Jul 12, 2018

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jul 12, 2018

CI passes (which is great!), but emits a bunch of warnings to the console like this:

babel-plugin-debug-macros configuration API has changed, please update your configuration

To fix those warnings we need to tweak this section:

ember-cli-babel/index.js

Lines 246 to 260 in 8d8c591

let options = {
envFlags: {
source: '@glimmer/env',
flags: { DEBUG: !isProduction, CI: !!process.env.CI }
},
externalizeHelpers: {
global: 'Ember'
},
debugTools: {
source: '@ember/debug',
assertPredicateIndex: 1
}
};

You can compare the "legacy config" test with this test in babel-plugin-debug-macros for an example.

I think we need something like:

let options = {
  externalizeHelpers: {
    global: "Ember"
  },
  debugTools: {
    isDebug: !isProduction,
    source: "@ember/debug",
    assertPredicateIndex: 1
  },
  flags: [
    {
      source: "@glimmer/env",
      flags: { DEBUG: !isProduction, CI: !!process.env.CI }
    }
  ]
};

@kellyselden kellyselden force-pushed the kellyselden:babel-plugin-debug-macros branch 2 times, most recently from 4991c78 to 48a57ae Jul 13, 2018

@kellyselden kellyselden force-pushed the kellyselden:babel-plugin-debug-macros branch from 48a57ae to 98e266d Jul 13, 2018

@kellyselden

This comment has been minimized.

Copy link
Member Author

kellyselden commented Jul 14, 2018

@rwjblue I made the changes you suggested, and now everything looks good.

@rwjblue
Copy link
Member

rwjblue left a comment

Looks good. Thank you!

@kellyselden kellyselden merged commit cb5a382 into babel:master Jul 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kellyselden kellyselden deleted the kellyselden:babel-plugin-debug-macros branch Jul 14, 2018

@rwjblue rwjblue added the enhancement label Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment