New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make processed file extensions configurable #236

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@buschtoens
Copy link
Contributor

buschtoens commented Aug 3, 2018

This adds an optional extensions property to the ember-cli-babel config hash and allows users to process files that don't end in .js.

For instance:

  let app = new EmberApp(defaults, {
    'ember-cli-babel': {
      extensions: ['js', 'ts']
    },
    babel: {
      plugins: [
        '@babel/transform-typescript',
        '@babel/proposal-class-properties',
        '@babel/proposal-object-rest-spread'
      ]
    }
  });

I branched off of v7.0.0-beta.3, because the latest commit bricked the package.json by referring to a package on the file system. I'll rebase, when this is fixed.

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Aug 3, 2018

I branched off of v7.0.0-beta.3, because the latest commit bricked the package.json by referring to a package on the file system.

:facepalm: sorry :(

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Aug 3, 2018

OK, just updated the branch (without the file: reference), though it is still failing ATM...

@buschtoens buschtoens force-pushed the buschtoens:feat/configurable-file-extensions branch from afcb4fa to 04c3dfd Aug 3, 2018

@buschtoens

This comment has been minimized.

Copy link
Contributor Author

buschtoens commented Aug 3, 2018

Haha, no worries. Thanks for fixing so quickly! I rebased the PR. 😊

@buschtoens buschtoens force-pushed the buschtoens:feat/configurable-file-extensions branch from 04c3dfd to 991327e Aug 6, 2018

@buschtoens

This comment has been minimized.

Copy link
Contributor Author

buschtoens commented Aug 6, 2018

@rwjblue Tests are . Can I get a :shipit: ? 😄

@buschtoens buschtoens force-pushed the buschtoens:feat/configurable-file-extensions branch from 991327e to b13d111 Aug 29, 2018

@buschtoens

This comment has been minimized.

Copy link
Contributor Author

buschtoens commented Aug 29, 2018

Rebased onto latest v7.0.0 master.

@rwjblue rwjblue changed the base branch from babel-7 to master Aug 29, 2018

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Aug 29, 2018

This looks good, I just changed the base branch of the PR to point at master so we can land...

@rwjblue rwjblue merged commit dd78011 into babel:master Aug 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue added the enhancement label Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment