New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `@ember/string` detection to work on itself #260

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
2 participants
@locks
Copy link
Contributor

locks commented Jan 9, 2019

When running the tests for @ember/string, ember-cli-babel does not detect it properly and tries to process the imports for that module, leading to a failed test run.

@locks locks force-pushed the locks:modules-blacklist-option branch from f672e60 to 01a718a Jan 12, 2019

@rwjblue
Copy link
Member

rwjblue left a comment

Hmmm. Isn't the fix needed here to actually tweak _emberStringDependencyPresent to be something like:

_emberStringDependencyPresent() {
  if (this.project.name() === '@ember/string') {
    return true;
  }

  let checker = new VersionChecker(this.parent).for('@ember/string', 'npm');	    
  return checker.exists();
},

@locks locks force-pushed the locks:modules-blacklist-option branch from 01a718a to 0c12ba4 Jan 15, 2019

@locks

This comment has been minimized.

Copy link
Contributor Author

locks commented Jan 15, 2019

@rwjblue 🤦‍♂️ updated.

@locks locks referenced this pull request Jan 15, 2019

Merged

v1.0.0 Polish #8

1 of 1 task complete

@locks locks changed the title Add emberModulesAPIPolyfillBlacklist options so ember string can exclude itself Update `@ember/string` detection to check if it is the project being run Jan 15, 2019

@rwjblue rwjblue merged commit 014852a into babel:master Jan 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue added the bug label Jan 22, 2019

@rwjblue rwjblue changed the title Update `@ember/string` detection to check if it is the project being run Update `@ember/string` detection to work on itself Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment