New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid transpiling jquery module to Ember.$ if @ember/jquery is present #261

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@simonihmig
Copy link
Contributor

simonihmig commented Jan 22, 2019

Skips transpiling import $ from 'jquery' if the right version (0.6.0) of @ember/jquery is present, that ships with its own vendor shim.

Blacklist jquery if @ember/jquery is present
Skips transpiling `import $ from 'jquery'` if the right version (0.6.0) of `@ember/jquery` is present, that ships with its own vendor shim.
Show resolved Hide resolved index.js
@simonihmig

This comment has been minimized.

Copy link
Contributor Author

simonihmig commented Jan 22, 2019

Failing appveyor seems to be caused by a network glitch...

@simonihmig simonihmig referenced this pull request Jan 22, 2019

Closed

[QUEST] Remove jQuery #17476

9 of 16 tasks complete

@rwjblue rwjblue merged commit 3c67b5d into babel:master Jan 22, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue added the internal label Jan 22, 2019

@rwjblue rwjblue changed the title Blacklist jquery if @ember/jquery is present Avoid transpiling jquery module to Ember.$ if @ember/jquery is present Jan 22, 2019

@simonihmig simonihmig deleted the simonihmig:blacklist-jquery branch Jan 22, 2019

@Turbo87 Turbo87 added enhancement and removed internal labels Jan 23, 2019

@kategengler kategengler referenced this pull request Feb 12, 2019

Open

RFC #0386 - Tracking for Remove jQuery by Default #3

9 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment