Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill that allows apps and addons to use `@ember-data` related packages regardless of `ember-data` version #318

Merged
merged 5 commits into from Jan 30, 2020

Conversation

@runspired
Copy link
Contributor

runspired commented Jan 15, 2020

No description provided.

index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@runspired runspired force-pushed the runspired:feat/ember-data-packages branch 2 times, most recently from 15574e4 to ead9fd6 Jan 29, 2020
@runspired runspired force-pushed the runspired:feat/ember-data-packages branch from ead9fd6 to 58b4483 Jan 29, 2020
@runspired runspired requested a review from rwjblue Jan 29, 2020
runspired added 2 commits Jan 29, 2020
@runspired

This comment has been minimized.

Copy link
Contributor Author

runspired commented Jan 29, 2020

The failing test is for node 6, which I believe we can safely drop.

Indeed this project currently tests 6,8, and 10 when we should bump to testing 10, 12 and 13

EDIT: @rwjblue requested the node 6/8 support drop be a separate effort later and not tied to any features. #321 has been created and node 6 support added here.

runspired added 2 commits Jan 29, 2020
@amyrlam amyrlam mentioned this pull request Jan 29, 2020
6 of 27 tasks complete
if (!dep.version) {
throw new Error('EmberData missing version');
}
Comment on lines +531 to +533

This comment has been minimized.

Copy link
@rwjblue

rwjblue Jan 30, 2020

Member

Do we ever expect this to actually happen? I think no, but just wanted to check and see why it was added...

This comment has been minimized.

Copy link
@runspired

runspired Jan 30, 2020

Author Contributor

When I was creating the test mock environment the failures were pretty obtuse, this made it clear when the issue was no version found so that I knew I needed to continue getting the mock env closer to what version checker needed.

It is removable.

@rwjblue rwjblue added the enhancement label Jan 30, 2020
@rwjblue rwjblue changed the title feat: EmberData Packages Polyfill Add polyfill that allows apps and addons to use `@ember-data` related packages regardless of `ember-data` version Jan 30, 2020
@rwjblue rwjblue merged commit 2ba3ef7 into babel:master Jan 30, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rwjblue added a commit that referenced this pull request Jan 30, 2020
… re… (#318)"

This reverts commit 2ba3ef7, reversing
changes made to f305de0.

Seeing issues with this in the wild, reverting so that we can
investigate.
@amyrlam amyrlam mentioned this pull request Feb 1, 2020
4 of 18 tasks complete
runspired added a commit to runspired/ember-cli-babel that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.