New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .npmignore and whitelists js files #83

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
4 participants
@twokul
Copy link
Contributor

twokul commented Aug 5, 2016

Makes sure to ignore files that are irrelevant when installing the package.

related to ember-cli/ember-cli#6147

@stefanpenner stefanpenner referenced this pull request Aug 5, 2016

Closed

reduce bite-size/file-count of ember-cli and its dep. #6147

8 of 22 tasks complete
@jonkoops

This comment has been minimized.

Copy link

jonkoops commented Aug 6, 2016

@twokul .npmignore can probably be removed entirely since the files key takes precedence.

@twokul twokul force-pushed the twokul:byte-shrink branch from 8241bed to 6596ea3 Aug 8, 2016

@@ -11,6 +11,10 @@
"start": "ember server",
"test": "ember test"
},
"files": [
"index.js",
"ember-cli-build.js"

This comment has been minimized.

@stefanpenner

stefanpenner Aug 8, 2016

Member

I don't believe this file is required

@@ -11,6 +11,10 @@
"start": "ember server",
"test": "ember test"
},
"files": [
"index.js",

This comment has been minimized.

@stefanpenner

stefanpenner Aug 8, 2016

Member

This one is

Whitelists js files
Makes sure to ignore files that are irrelevant when installing the package.

@twokul twokul force-pushed the twokul:byte-shrink branch from 6596ea3 to 376e638 Aug 8, 2016

@stefanpenner stefanpenner merged commit 98ac5b1 into babel:master Aug 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@twokul twokul deleted the twokul:byte-shrink branch Aug 8, 2016

@Turbo87 Turbo87 added the internal label Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment