Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds .npmignore and whitelists js files #83
Conversation
stefanpenner
referenced this pull request
Aug 5, 2016
Closed
reduce bite-size/file-count of ember-cli and its dep. #6147
This comment has been minimized.
This comment has been minimized.
jonkoops
commented
Aug 6, 2016
|
@twokul .npmignore can probably be removed entirely since the |
twokul
force-pushed the
twokul:byte-shrink
branch
from
8241bed
to
6596ea3
Aug 8, 2016
stefanpenner
reviewed
Aug 8, 2016
package.json
Outdated
| @@ -11,6 +11,10 @@ | |||
| "start": "ember server", | |||
| "test": "ember test" | |||
| }, | |||
| "files": [ | |||
| "index.js", | |||
| "ember-cli-build.js" | |||
This comment has been minimized.
This comment has been minimized.
stefanpenner
reviewed
Aug 8, 2016
package.json
Outdated
| @@ -11,6 +11,10 @@ | |||
| "start": "ember server", | |||
| "test": "ember test" | |||
| }, | |||
| "files": [ | |||
| "index.js", | |||
This comment has been minimized.
This comment has been minimized.
twokul
force-pushed the
twokul:byte-shrink
branch
from
6596ea3
to
376e638
Aug 8, 2016
stefanpenner
merged commit 98ac5b1
into
babel:master
Aug 8, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
twokul
deleted the
twokul:byte-shrink
branch
Aug 8, 2016
Turbo87
added
the
internal
label
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
twokul commentedAug 5, 2016
Makes sure to ignore files that are irrelevant when installing the package.
related to ember-cli/ember-cli#6147